Update Rust crate temporalio-common to c5a6646#8421
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview Reviewers should confirm Cargo.lock resolves cleanly and that mixed SDK-core commits between Reviewed by Cursor Bugbot for commit 3aee5b4. Bugbot is set up for automated code reviews on this repo. Configure here. |
🤖 Augment PR SummarySummary: This PR updates the pinned git revision for the Rust crate Changes:
Technical Notes: Since both crates come from the same upstream repository, mixing revisions may result in multiple git checkouts/duplicate crate versions unless they are intentionally kept independent. 🤖 Was this summary useful? React with 👍 or 👎 |
| temporalio-client = { git = "https://github.com/temporalio/sdk-core", rev = "231e21c" } | ||
| temporalio-common = { git = "https://github.com/temporalio/sdk-core", rev = "231e21c" } | ||
| temporalio-common = { git = "https://github.com/temporalio/sdk-core", rev = "fb14d9c3cf4e9e6d0894fd9bb2985dbf6d6de1fe" } | ||
| test-log = { version = "0.2.18", default-features = false } |
There was a problem hiding this comment.
temporalio-common is now pinned to a different git rev than temporalio-client (same upstream repo), which can cause Cargo to pull two distinct copies and potentially lead to type/version mismatches. Is it expected that these two crates are compatible across different commits, or should they be bumped together to the same rev?
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8421 +/- ##
==========================================
- Coverage 59.13% 59.13% -0.01%
==========================================
Files 1346 1346
Lines 130096 130096
Branches 5883 5883
==========================================
- Hits 76931 76930 -1
- Misses 52259 52260 +1
Partials 906 906
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will improve performance by 18.18%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | bit_matrix/dense/iter_row[64] |
170 ns | 140.8 ns | +20.71% |
| ⚡ | bit_matrix/dense/iter_row[200] |
215 ns | 185.8 ns | +15.7% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing deps/rs/temporalio-common-digest (3aee5b4) with main (232b539)
Footnotes
-
24 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
58f81bb to
b8b4e23
Compare
temporalio-common to fb14d9ctemporalio-common to 20a6817
temporalio-common to 20a6817temporalio-common to 12c656f
b8b4e23 to
b67cdc2
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
temporalio-common to 12c656ftemporalio-common to f16f160
temporalio-common to 21e03c2temporalio-common to 2014f31
133dd13 to
694fa8b
Compare
temporalio-common to 2014f31temporalio-common to a0caec4
694fa8b to
c7fbc51
Compare
c7fbc51 to
9ff8edf
Compare
temporalio-common to a0caec4temporalio-common to 9d678b9
temporalio-common to 9d678b9temporalio-common to 78a94de
9ff8edf to
34cbc3a
Compare
temporalio-common to 78a94detemporalio-common to 7161ed3
|
This PR contains the following updates:
231e21c→c5a6646Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.